-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load the app/SP from the environment instead of automatically creating it #3498
Conversation
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Did you manage to check that all the generated resources were indeed cleaned up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at it again I'm now very sure that removing the portal v1 line from the .gitignore
will cause us issues
/azp run ci e2e |
No pipelines are associated with this pull request. |
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run e2e, ci |
Azure Pipelines successfully started running 2 pipeline(s). |
get_cluster_sp() { | ||
echo "########## Downloading SP secrets ##########" | ||
|
||
az keyvault secret download --vault-name=aro-e2e-principals \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking the PR, but we should add a TODO here for eventually grabbing a single SP among the entire pool
…g it (#3498) * use multierror here, so it's more obvious if we're missing multiple keys * Ignore the written out clusterapp.env * move create/delete into separate commands, which write out a clusterapp.env file * delete the app in the e2e.sh file * update the docs
Which issue this PR addresses:
Part of ARO-5822
What this PR does / why we need it:
Loads the application and SP secret from the env, instead of automatically creating it. This allows us to load them from a fixed pool in the e2e process, instead of creating new ones each time.
Test plan for issue:
Manually tested creating a cluster locally with the steps updated in the docs
Is there any documentation that needs to be updated for this PR?
Updated dev RP docs
How do you know this will function as expected in production?
Purely CI/E2E/dev changes -- more will need to happen for prod e2e